|author||Michał Górny <firstname.lastname@example.org>||2010-07-18 10:26:40 +0200|
|committer||Michal Marek <email@example.com>||2010-07-20 15:43:27 +0200|
|parent||Linux 2.6.35-rc5 (diff)|
kbuild: Make the setlocalversion script POSIX-compliant
The 'source' builtin is a bash alias to the '.' (dot) builtin. While the former is supported only by bash, the latter is specified in POSIX and works fine with all POSIX-compliant shells I am aware of. The '$_' special parameter is specific to bash. It is partially supported in dash too but it always evaluates to the current script path (which causes the script to enter a loop recursively re-executing itself). This is why I have replaced the two occurences of '$_' with the explicit parameter. The 'local' builtin is another example of bash-specific code. Although it is supported by all POSIX-compliant shells I am aware of, it is not part of POSIX specification and thus the code should not rely on it assigning a specific value to the local variable. Moreover, the 'posh' shell has a limited version of 'local' builtin not supporting direct variable assignments. Thus, I have broken one of the 'local' declarations down into a (non-POSIX) 'local' declaration and a plain (POSIX-compliant) variable assignment. Signed-off-by: Michał Górny <firstname.lastname@example.org> Signed-off-by: Michal Marek <email@example.com>
1 files changed, 4 insertions, 3 deletions
diff --git a/scripts/setlocalversion b/scripts/setlocalversion
index d6a866ed1835..a7b9f7607e13 100755
@@ -30,11 +30,12 @@ fi
- local short=false
+ local short
if test -e .scmversion; then
- cat "$_"
+ cat .scmversion
if test "$1" = "--short"; then
@@ -136,7 +137,7 @@ if $scm_only; then
if test -e include/config/auto.conf; then
- source "$_"
+ . include/config/auto.conf
echo "Error: kernelrelease not valid - run 'make prepare' to update it"