diff options
| author |   Peng Wu <wupeng58@huawei.com> | 2022-09-11 06:00:53 +0000 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2022-11-05 00:29:57 +0530 |
| commit | 6e59419fd0a244dd55e53e798797f0697dec8b1c (patch) | |
| tree | c66b6b094942f85f2e1c4b4f7ff85a23d91b178f | |
| parent | phy: qcom-qmp-combo: fix NULL-deref on runtime resume (diff) | |
| download | linux-dev-6e59419fd0a244dd55e53e798797f0697dec8b1c.tar.xz linux-dev-6e59419fd0a244dd55e53e798797f0697dec8b1c.zip | |
phy: sunplus: Fix an IS_ERR() vs NULL bug in sp_usb_phy_probe
The devm_ioremap() function returns NULL on error, it doesn't return
error pointers.
Fixes: 99d9ccd973852 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
Signed-off-by: Peng Wu <wupeng58@huawei.com>
Link: https://lore.kernel.org/r/20220911060053.123594-1-wupeng58@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/phy/sunplus/phy-sunplus-usb2.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c index b932087c55b2..e827b79f6d49 100644 --- a/drivers/phy/sunplus/phy-sunplus-usb2.c +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c @@ -256,8 +256,8 @@ static int sp_usb_phy_probe(struct platform_device *pdev) usbphy->moon4_res_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "moon4"); usbphy->moon4_regs = devm_ioremap(&pdev->dev, usbphy->moon4_res_mem->start, resource_size(usbphy->moon4_res_mem)); - if (IS_ERR(usbphy->moon4_regs)) - return PTR_ERR(usbphy->moon4_regs); + if (!usbphy->moon4_regs) + return -ENOMEM; usbphy->phy_clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(usbphy->phy_clk)) |