diff options
| author |   Fabio Estevam <festevam@gmail.com> | 2011-03-16 22:52:33 -0300 |
|---|---|---|
| committer |   Sascha Hauer <s.hauer@pengutronix.de> | 2011-03-23 15:07:48 +0100 |
| commit | 6ea6392cc4ff9214c7356e8ca71244c006a95ddb (patch) | |
| tree | 9278e6ca0211062a5f7c91db2aafc4c52980ba05 | |
| parent | ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset (diff) | |
| download | linux-dev-6ea6392cc4ff9214c7356e8ca71244c006a95ddb.tar.xz linux-dev-6ea6392cc4ff9214c7356e8ca71244c006a95ddb.zip | |
ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset
Current code inside mx53_evk_fec_reset uses gpio_direction_output with initial value of the GPIO and also sets
the GPIO value via gpio_set_value right after. This is not needed.
By using gpio_request_one it is possible to set the direction and initial value in one shot.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| -rw-r--r-- | arch/arm/mach-mx5/board-mx53_evk.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/arch/arm/mach-mx5/board-mx53_evk.c b/arch/arm/mach-mx5/board-mx53_evk.c index 7b5735c5ea59..d771999a1672 100644 --- a/arch/arm/mach-mx5/board-mx53_evk.c +++ b/arch/arm/mach-mx5/board-mx53_evk.c @@ -82,13 +82,12 @@ static inline void mx53_evk_fec_reset(void) int ret; /* reset FEC PHY */ - ret = gpio_request(SMD_FEC_PHY_RST, "fec-phy-reset"); + ret = gpio_request_one(SMD_FEC_PHY_RST, GPIOF_OUT_INIT_LOW, + "fec-phy-reset"); if (ret) { printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret); return; } - gpio_direction_output(SMD_FEC_PHY_RST, 0); - gpio_set_value(SMD_FEC_PHY_RST, 0); msleep(1); gpio_set_value(SMD_FEC_PHY_RST, 1); } |