diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-09-23 22:11:13 +0200 |
|---|---|---|
| committer |   Guenter Roeck <linux@roeck-us.net> | 2021-09-24 05:02:24 -0700 |
| commit | 6f7d70467121f790b36af2d84bc02b5c236bf5e6 (patch) | |
| tree | 763ba70e6bbd1c0650f5a7e2c4064cfd87ce865d | |
| parent | hwmon: (tmp421) fix rounding for negative values (diff) | |
| download | linux-dev-6f7d70467121f790b36af2d84bc02b5c236bf5e6.tar.xz linux-dev-6f7d70467121f790b36af2d84bc02b5c236bf5e6.zip | |
hwmon: (ltc2947) Properly handle errors when looking for the external clock
The return value of devm_clk_get should in general be propagated to
upper layer. In this case the clk is optional, use the appropriate
wrapper instead of interpreting all errors as "The optional clk is not
available".
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210923201113.398932-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/ltc2947-core.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/hwmon/ltc2947-core.c b/drivers/hwmon/ltc2947-core.c index bb3f7749a0b0..5423466de697 100644 --- a/drivers/hwmon/ltc2947-core.c +++ b/drivers/hwmon/ltc2947-core.c @@ -989,8 +989,12 @@ static int ltc2947_setup(struct ltc2947_data *st) return ret; /* check external clock presence */ - extclk = devm_clk_get(st->dev, NULL); - if (!IS_ERR(extclk)) { + extclk = devm_clk_get_optional(st->dev, NULL); + if (IS_ERR(extclk)) + return dev_err_probe(st->dev, PTR_ERR(extclk), + "Failed to get external clock\n"); + + if (extclk) { unsigned long rate_hz; u8 pre = 0, div, tbctl; u64 aux; |