aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEryu Guan <guaneryu@gmail.com>2016-02-21 18:38:44 -0500
committerTheodore Ts'o <tytso@mit.edu>2016-03-09 21:37:53 -0500
commit6ffe77bad545f4a7c8edd2a4ee797ccfcd894ab4 (patch)
tree842dcd9b2f4a8d82df26d11e9c22779ec7b9894d
parentext2, ext4: fix issue with missing journal entry in ext4_dax_mkwrite() (diff)
downloadlinux-dev-6ffe77bad545f4a7c8edd2a4ee797ccfcd894ab4.tar.xz
linux-dev-6ffe77bad545f4a7c8edd2a4ee797ccfcd894ab4.zip
ext4: iterate over buffer heads correctly in move_extent_per_page()
In commit bcff24887d00 ("ext4: don't read blocks from disk after extents being swapped") bh is not updated correctly in the for loop and wrong data has been written to disk. generic/324 catches this on sub-page block size ext4. Fixes: bcff24887d00 ("ext4: don't read blocks from disk after extentsbeing swapped") Signed-off-by: Eryu Guan <guaneryu@gmail.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-rw-r--r--fs/ext4/move_extent.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index e032a0423e35..4098acc701c3 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -390,6 +390,7 @@ data_copy:
*err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0);
if (*err < 0)
break;
+ bh = bh->b_this_page;
}
if (!*err)
*err = block_commit_write(pagep[0], from, from + replaced_size);