diff options
| author |   Sudip Mukherjee <sudipm.mukherjee@gmail.com> | 2015-07-21 18:57:26 +0530 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-07-22 20:59:54 -0700 |
| commit | 705a31369845d7ad522dc9bce6ca430831ff0454 (patch) | |
| tree | 455229b483e7d9e8767b5a1492bece86f201d923 | |
| parent | staging: rtl8188eu: remove label (diff) | |
staging: rtl8188eu: check for kzalloc failure
Check for kzalloc failure and directly return from the error patch thus
simplifying the success path.
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/rtl8188eu/os_dep/usb_intf.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index 09a918ec6e10..1c9558ff1c19 100644 --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c @@ -114,13 +114,12 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf) mutex_init(&pdvobjpriv->usb_vendor_req_mutex); pdvobjpriv->usb_vendor_req_buf = kzalloc(MAX_USB_IO_CTL_SIZE, GFP_KERNEL); - if (pdvobjpriv->usb_vendor_req_buf) { - usb_get_dev(pusbd); - } else { + if (!pdvobjpriv->usb_vendor_req_buf) { usb_set_intfdata(usb_intf, NULL); kfree(pdvobjpriv); - pdvobjpriv = NULL; + return NULL; } + usb_get_dev(pusbd); return pdvobjpriv; } |