aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVasu Dev <vasu.dev@intel.com>2010-05-07 15:18:19 -0700
committerJames Bottomley <James.Bottomley@suse.de>2010-05-16 22:22:27 -0400
commit721cafafb66f57b461226aa197997f3e5b296f91 (patch)
tree6be6c819f0d1dd4d6230ccc3d7f53420cea6873f
parent[SCSI] libfc: set seq_id for incoming sequence (diff)
downloadlinux-dev-721cafafb66f57b461226aa197997f3e5b296f91.tar.xz
linux-dev-721cafafb66f57b461226aa197997f3e5b296f91.zip
[SCSI] fcoe: fixes wrong error exit in fcoe_create
fcoe_create exits using out_nodev label when module is not yet LIVE but this exit path unlocks the rtnl_lock though rtnl lock was not held in this case. So this patch replaces out_nodev with out_nomod to exit w/o unlocking rtnl_lock. Signed-off-by: Vasu Dev <vasu.dev@intel.com> Signed-off-by: Robert Love <robert.w.love@intel.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
-rw-r--r--drivers/scsi/fcoe/fcoe.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index aba839e68014..7022a16b14f6 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -2056,7 +2056,7 @@ static int fcoe_create(const char *buffer, struct kernel_param *kp)
*/
if (THIS_MODULE->state != MODULE_STATE_LIVE) {
rc = -ENODEV;
- goto out_nodev;
+ goto out_nomod;
}
#endif