diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2020-07-16 22:52:42 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-07-17 12:57:59 -0700 |
| commit | 721dab2b56535b06f9d5756cf27d875623cb5a60 (patch) | |
| tree | b8ab396092fd6adcefe27b0d8bd4d6f74c68c34a | |
| parent | net: alteon: switch from 'pci_' to 'dma_' API (diff) | |
| download | linux-dev-721dab2b56535b06f9d5756cf27d875623cb5a60.tar.xz linux-dev-721dab2b56535b06f9d5756cf27d875623cb5a60.zip | |
net: alteon: Avoid some useless memset
Avoid a memset after a call to 'dma_alloc_coherent()'.
This is useless since
commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*")
Replace a kmalloc+memset with a corresponding kzalloc.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/alteon/acenic.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/ethernet/alteon/acenic.c b/drivers/net/ethernet/alteon/acenic.c index 99431c9a899b..ac86fcae1582 100644 --- a/drivers/net/ethernet/alteon/acenic.c +++ b/drivers/net/ethernet/alteon/acenic.c @@ -1151,7 +1151,7 @@ static int ace_init(struct net_device *dev) /* * Get the memory for the skb rings. */ - if (!(ap->skb = kmalloc(sizeof(struct ace_skb), GFP_KERNEL))) { + if (!(ap->skb = kzalloc(sizeof(struct ace_skb), GFP_KERNEL))) { ecode = -EAGAIN; goto init_error; } @@ -1172,9 +1172,6 @@ static int ace_init(struct net_device *dev) ap->last_mini_rx = 0; #endif - memset(ap->info, 0, sizeof(struct ace_info)); - memset(ap->skb, 0, sizeof(struct ace_skb)); - ecode = ace_load_firmware(dev); if (ecode) goto init_error; |