aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Manning <mmanning@vyatta.att-mail.com>2019-05-20 19:57:17 +0100
committerDavid S. Miller <davem@davemloft.net>2019-05-21 13:12:39 -0700
commit72f7cfab6f93a8ea825fab8ccfb016d064269f7f (patch)
treedcbd4bedc6d143fa16e92d4fec8b3121c9bcc57c
parentnet: phylink: ensure inband AN works correctly (diff)
downloadlinux-dev-72f7cfab6f93a8ea825fab8ccfb016d064269f7f.tar.xz
linux-dev-72f7cfab6f93a8ea825fab8ccfb016d064269f7f.zip
ipv6: Consider sk_bound_dev_if when binding a raw socket to an address
IPv6 does not consider if the socket is bound to a device when binding to an address. The result is that a socket can be bound to eth0 and then bound to the address of eth1. If the device is a VRF, the result is that a socket can only be bound to an address in the default VRF. Resolve by considering the device if sk_bound_dev_if is set. Signed-off-by: Mike Manning <mmanning@vyatta.att-mail.com> Reviewed-by: David Ahern <dsahern@gmail.com> Tested-by: David Ahern <dsahern@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/raw.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 84dbe21b71e5..96a3559f2a09 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -287,7 +287,9 @@ static int rawv6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
/* Binding to link-local address requires an interface */
if (!sk->sk_bound_dev_if)
goto out_unlock;
+ }
+ if (sk->sk_bound_dev_if) {
err = -ENODEV;
dev = dev_get_by_index_rcu(sock_net(sk),
sk->sk_bound_dev_if);