diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2022-01-11 10:19:22 +0300 |
|---|---|---|
| committer |   Alexandre Belloni <alexandre.belloni@bootlin.com> | 2022-01-16 23:34:43 +0100 |
| commit | 7372971c1be5b7d4fdd8ad237798bdc1d1d54162 (patch) | |
| tree | 9668afb5ce50886eaa6480546cce3809495e01ca | |
| parent | dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers (diff) | |
| download | linux-dev-7372971c1be5b7d4fdd8ad237798bdc1d1d54162.tar.xz linux-dev-7372971c1be5b7d4fdd8ad237798bdc1d1d54162.zip | |
rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
The mc146818_get_time() function returns zero on success or negative
a error code on failure. It needs to be type int.
Fixes: d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220111071922.GE11243@kili
| -rw-r--r-- | drivers/rtc/rtc-mc146818-lib.c | 2 | ||||
| -rw-r--r-- | include/linux/mc146818rtc.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c index f62e658cbe23..7f689f1bafc5 100644 --- a/drivers/rtc/rtc-mc146818-lib.c +++ b/drivers/rtc/rtc-mc146818-lib.c @@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in) p->ctrl = CMOS_READ(RTC_CONTROL); } -unsigned int mc146818_get_time(struct rtc_time *time) +int mc146818_get_time(struct rtc_time *time) { struct mc146818_get_time_callback_param p = { .time = time diff --git a/include/linux/mc146818rtc.h b/include/linux/mc146818rtc.h index 67fb0a12becc..808bb4cee230 100644 --- a/include/linux/mc146818rtc.h +++ b/include/linux/mc146818rtc.h @@ -124,7 +124,7 @@ struct cmos_rtc_board_info { #endif /* ARCH_RTC_LOCATION */ bool mc146818_does_rtc_work(void); -unsigned int mc146818_get_time(struct rtc_time *time); +int mc146818_get_time(struct rtc_time *time); int mc146818_set_time(struct rtc_time *time); bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param), |