diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2021-06-07 21:38:37 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-07 14:07:22 -0700 |
| commit | 74325bf0104573c6dfce42837139aeef3f34be76 (patch) | |
| tree | 3c6eae205f4b3b7064e30b0b9475bdc84da8b71a | |
| parent | net: tulip: Remove the repeated declaration (diff) | |
| download | linux-dev-74325bf0104573c6dfce42837139aeef3f34be76.tar.xz linux-dev-74325bf0104573c6dfce42837139aeef3f34be76.zip | |
net: bcmgenet: check return value after calling platform_get_resource()
It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 5335244e4577..89d16c587bb7 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -423,6 +423,10 @@ static int bcmgenet_mii_register(struct bcmgenet_priv *priv) int id, ret; pres = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!pres) { + dev_err(&pdev->dev, "Invalid resource\n"); + return -EINVAL; + } memset(&res, 0, sizeof(res)); memset(&ppd, 0, sizeof(ppd)); |