diff options
| author |   Fabian Frederick <fabf@skynet.be> | 2014-05-20 18:50:16 +0200 |
|---|---|---|
| committer |   Jan Kara <jack@suse.cz> | 2014-05-21 10:26:13 +0200 |
| commit | 770901cc1352b46f0e2de08260ec40c0364d7723 (patch) | |
| tree | 6f6826ca0773a7dfb765a29efacdef204316fe46 | |
| parent | reiserfs: remove obsolete __constant_cpu_to_le32 (diff) | |
| download | linux-dev-770901cc1352b46f0e2de08260ec40c0364d7723.tar.xz linux-dev-770901cc1352b46f0e2de08260ec40c0364d7723.zip | |
fs/jbd/revoke.c: replace shift loop by ilog2
journal_init_revoke_table is only called with positive hash_size
(JOURNAL_REVOKE_DEFAULT_HASH) so we can replace loop shift by ilog2
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Jan Kara <jack@suse.cz>
| -rw-r--r-- | fs/jbd/revoke.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/fs/jbd/revoke.c b/fs/jbd/revoke.c index 25c713e7071c..8898bbd2b61e 100644 --- a/fs/jbd/revoke.c +++ b/fs/jbd/revoke.c @@ -231,19 +231,15 @@ record_cache_failure: static struct jbd_revoke_table_s *journal_init_revoke_table(int hash_size) { - int shift = 0; - int tmp = hash_size; + int i; struct jbd_revoke_table_s *table; table = kmem_cache_alloc(revoke_table_cache, GFP_KERNEL); if (!table) goto out; - while((tmp >>= 1UL) != 0UL) - shift++; - table->hash_size = hash_size; - table->hash_shift = shift; + table->hash_shift = ilog2(hash_size); table->hash_table = kmalloc(hash_size * sizeof(struct list_head), GFP_KERNEL); if (!table->hash_table) { @@ -252,8 +248,8 @@ static struct jbd_revoke_table_s *journal_init_revoke_table(int hash_size) goto out; } - for (tmp = 0; tmp < hash_size; tmp++) - INIT_LIST_HEAD(&table->hash_table[tmp]); + for (i = 0; i < hash_size; i++) + INIT_LIST_HEAD(&table->hash_table[i]); out: return table; |