diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2018-10-08 21:47:36 +0100 |
|---|---|---|
| committer |   Ben Skeggs <bskeggs@redhat.com> | 2019-02-20 08:59:58 +1000 |
| commit | 785cf1eeafa23ec63f426d322401054d13abe2a3 (patch) | |
| tree | 33a79a780c9fc0423d8bd6534939514fb6201d19 | |
| parent | drm/nouveau: mark expected switch fall-through (diff) | |
| download | linux-dev-785cf1eeafa23ec63f426d322401054d13abe2a3.tar.xz linux-dev-785cf1eeafa23ec63f426d322401054d13abe2a3.zip | |
drm/nouveau: fix missing break in switch statement
The NOUVEAU_GETPARAM_PCI_DEVICE case is missing a break statement and falls
through to the following NOUVEAU_GETPARAM_BUS_TYPE case and may end up
re-assigning the getparam->value to an undesired value. Fix this by adding
in the missing break.
Detected by CoverityScan, CID#1460507 ("Missing break in switch")
Fixes: 359088d5b8ec ("drm/nouveau: remove trivial cases of nvxx_device() usage")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/nouveau/nouveau_abi16.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c index b06cdac8f3a2..a95ec3783f39 100644 --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c @@ -214,6 +214,7 @@ nouveau_abi16_ioctl_getparam(ABI16_IOCTL_ARGS) WARN_ON(1); break; } + break; case NOUVEAU_GETPARAM_FB_SIZE: getparam->value = drm->gem.vram_available; break; |