diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-23 16:13:07 +0530 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-07-23 13:37:16 -0700 |
| commit | 78e420408d12eddd0e72613fc717f7994736ea9a (patch) | |
| tree | eaa15b42aada333bce8de04e661c3436a4ee8944 | |
| parent | Merge branch 'selftests-forwarding-GRE-multipath-fixes' (diff) | |
| download | linux-dev-78e420408d12eddd0e72613fc717f7994736ea9a.tar.xz linux-dev-78e420408d12eddd0e72613fc717f7994736ea9a.zip | |
net: dsa: mv88e6xxx: chip: Add of_node_put() before return
Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/dsa/mv88e6xxx/chip.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 6b17cd961d06..c97dea4599a8 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2721,6 +2721,7 @@ static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip, err = mv88e6xxx_mdio_register(chip, child, true); if (err) { mv88e6xxx_mdios_unregister(chip); + of_node_put(child); return err; } } |