diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2022-07-15 13:35:18 +0300 |
|---|---|---|
| committer |   Kalle Valo <quic_kvalo@quicinc.com> | 2022-07-18 13:04:11 +0300 |
| commit | 7a4836560a6198d245d5732e26f94898b12eb760 (patch) | |
| tree | 0ef3d708f58e2cf65c63f48c804ec47e0866d3b0 | |
| parent | wifi: ath5k: fix repeated words in comments (diff) | |
| download | linux-dev-7a4836560a6198d245d5732e26f94898b12eb760.tar.xz linux-dev-7a4836560a6198d245d5732e26f94898b12eb760.zip | |
wifi: wil6210: debugfs: fix info leak in wil_write_file_wmi()
The simple_write_to_buffer() function will succeed if even a single
byte is initialized. However, we need to initialize the whole buffer
to prevent information leaks. Just use memdup_user().
Fixes: ff974e408334 ("wil6210: debugfs interface to send raw WMI command")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/Ysg14NdKAZF/hcNG@kili
| -rw-r--r-- | drivers/net/wireless/ath/wil6210/debugfs.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c index 64d6c98174c8..fe84362718de 100644 --- a/drivers/net/wireless/ath/wil6210/debugfs.c +++ b/drivers/net/wireless/ath/wil6210/debugfs.c @@ -1012,18 +1012,12 @@ static ssize_t wil_write_file_wmi(struct file *file, const char __user *buf, u16 cmdid; int rc, rc1; - if (cmdlen < 0) + if (cmdlen < 0 || *ppos != 0) return -EINVAL; - wmi = kmalloc(len, GFP_KERNEL); - if (!wmi) - return -ENOMEM; - - rc = simple_write_to_buffer(wmi, len, ppos, buf, len); - if (rc < 0) { - kfree(wmi); - return rc; - } + wmi = memdup_user(buf, len); + if (IS_ERR(wmi)) + return PTR_ERR(wmi); cmd = (cmdlen > 0) ? &wmi[1] : NULL; cmdid = le16_to_cpu(wmi->command_id); |