diff options
| author |   Chen Zhou <chenzhou10@huawei.com> | 2020-01-22 09:32:40 +0800 |
|---|---|---|
| committer |   Lee Jones <lee.jones@linaro.org> | 2020-01-23 07:53:12 +0000 |
| commit | 7af43a76695db71a57203793fb9dd3c81a5783b1 (patch) | |
| tree | 6d8959cc0d01902904aaf89afc6126be4581e56d | |
| parent | backlight: bd6107: Convert to use GPIO descriptor (diff) | |
| download | linux-dev-7af43a76695db71a57203793fb9dd3c81a5783b1.tar.xz linux-dev-7af43a76695db71a57203793fb9dd3c81a5783b1.zip | |
backlight: qcom-wled: Fix unsigned comparison to zero
Fixes coccicheck warning:
./drivers/video/backlight/qcom-wled.c:1104:5-15:
WARNING: Unsigned expression compared with zero: string_len > 0
The unsigned variable string_len is assigned a return value from the call
to of_property_count_elems_of_size(), which may return negative error code.
Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Kiran Gunda <kgunda@codeaurora.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
| -rw-r--r-- | drivers/video/backlight/qcom-wled.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index d46052d8ff41..3d276b30a78c 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int version) struct wled_config *cfg = &wled->cfg; struct device *dev = wled->dev; const __be32 *prop_addr; - u32 size, val, c, string_len; - int rc, i, j; + u32 size, val, c; + int rc, i, j, string_len; const struct wled_u32_opts *u32_opts = NULL; const struct wled_u32_opts wled3_opts[] = { |