diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-18 10:26:47 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-20 10:14:50 +0100 |
| commit | 7c6f2a86ca590d5187a073d987e9599985fb1c7c (patch) | |
| tree | cb43cab8bc7fc689fd07c2b71483392ad16a4a46 | |
| parent | tcp: Fix data-races around sysctl_tcp_recovery. (diff) | |
| download | linux-dev-7c6f2a86ca590d5187a073d987e9599985fb1c7c.tar.xz linux-dev-7c6f2a86ca590d5187a073d987e9599985fb1c7c.zip | |
tcp: Fix a data-race around sysctl_tcp_thin_linear_timeouts.
While reading sysctl_tcp_thin_linear_timeouts, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its reader.
Fixes: 36e31b0af587 ("net: TCP thin linear timeouts")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/tcp_timer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c index ec5277becc6a..50bba370486e 100644 --- a/net/ipv4/tcp_timer.c +++ b/net/ipv4/tcp_timer.c @@ -578,7 +578,7 @@ out_reset_timer: * linear-timeout retransmissions into a black hole */ if (sk->sk_state == TCP_ESTABLISHED && - (tp->thin_lto || net->ipv4.sysctl_tcp_thin_linear_timeouts) && + (tp->thin_lto || READ_ONCE(net->ipv4.sysctl_tcp_thin_linear_timeouts)) && tcp_stream_is_thin(tp) && icsk->icsk_retransmits <= TCP_THIN_LINEAR_RETRIES) { icsk->icsk_backoff = 0; |