diff options
| author |   Vaibhav Gupta <vaibhavgupta40@gmail.com> | 2020-11-02 22:17:05 +0530 |
|---|---|---|
| committer |   Martin K. Petersen <martin.petersen@oracle.com> | 2020-11-25 23:14:29 -0500 |
| commit | 7dd2222180762656ccaf9e42ecc289f59fd43bc4 (patch) | |
| tree | 66b27f66843e0dea9043635213a4a8a09a27f23f | |
| parent | scsi: megaraid_sas: Update function description (diff) | |
| download | linux-dev-7dd2222180762656ccaf9e42ecc289f59fd43bc4.tar.xz linux-dev-7dd2222180762656ccaf9e42ecc289f59fd43bc4.zip | |
scsi: aacraid: Drop pci_enable_wake() from .resume
The driver calls pci_enable_wake(...., false) in aac_resume(), and there is
no corresponding pci_enable_wake(...., true) in aac_suspend(). Either it
should do enable-wake the device in .suspend() or should not invoke
pci_enable_wake() at all.
Concluding that this is a bug and PCI core calls pci_enable_wake(pci_dev,
PCI_D0, false) during resume, drop it from aac_resume().
Link: https://lore.kernel.org/r/20201102164730.324035-5-vaibhavgupta40@gmail.com
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/aacraid/linit.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 0a82afaf4028..114690bef76a 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -1881,7 +1881,6 @@ static int aac_resume(struct pci_dev *pdev) int r; pci_set_power_state(pdev, PCI_D0); - pci_enable_wake(pdev, PCI_D0, 0); pci_restore_state(pdev); r = pci_enable_device(pdev); |