diff options
| author |   Vaibhav Gupta <vaibhavgupta40@gmail.com> | 2020-11-02 22:17:24 +0530 |
|---|---|---|
| committer |   Martin K. Petersen <martin.petersen@oracle.com> | 2020-11-25 23:23:21 -0500 |
| commit | 7ea03ab79e00fccd2a12c1526fb3c7703c8a7baa (patch) | |
| tree | b5eb8a550feeeccd02bc5fb7784113be3e7cf861 | |
| parent | scsi: 3w-9xxx: Use generic power management (diff) | |
| download | linux-dev-7ea03ab79e00fccd2a12c1526fb3c7703c8a7baa.tar.xz linux-dev-7ea03ab79e00fccd2a12c1526fb3c7703c8a7baa.zip | |
scsi: 3w-sas: Drop PCI Wakeup calls from .resume
The driver calls pci_enable_wake(...., false) in twl_resume(), and there is
no corresponding pci_enable_wake(...., true) in twl_suspend(). Either it
should do enable-wake the device in .suspend() or should not invoke
pci_enable_wake() at all.
Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
twl_resume().
Link: https://lore.kernel.org/r/20201102164730.324035-24-vaibhavgupta40@gmail.com
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/3w-sas.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c index dda6fa857709..0b4888199699 100644 --- a/drivers/scsi/3w-sas.c +++ b/drivers/scsi/3w-sas.c @@ -1795,7 +1795,6 @@ static int twl_resume(struct pci_dev *pdev) printk(KERN_WARNING "3w-sas: Resuming host %d.\n", tw_dev->host->host_no); pci_set_power_state(pdev, PCI_D0); - pci_enable_wake(pdev, PCI_D0, 0); pci_restore_state(pdev); retval = pci_enable_device(pdev); |