aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>2022-04-28 14:10:56 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-05-05 21:57:32 +0200
commit7fd069d65da2e20b1caec3b7bcf9dfbe28c04bb2 (patch)
tree297c0aac697d997bb60d195a769395f1bb0a65d4
parentusb: core: acpi: Use the sysdev pointer instead of controller device (diff)
downloadlinux-dev-7fd069d65da2e20b1caec3b7bcf9dfbe28c04bb2.tar.xz
linux-dev-7fd069d65da2e20b1caec3b7bcf9dfbe28c04bb2.zip
usb: dwc3: host: Stop setting the ACPI companion
It is no longer needed. The sysdev pointer is now used when assigning the ACPI companions to the xHCI ports and USB devices. Assigning the ACPI companion here resulted in the fwnode->secondary pointer to be replaced also for the parent dwc3 device since the primary fwnode (the ACPI companion) was shared. That was unintentional and it created potential side effects like resource leaks. Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/20220428111056.3558-3-heikki.krogerus@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/dwc3/host.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index eda871973d6c..f56c30cf151e 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -7,7 +7,6 @@
* Authors: Felipe Balbi <balbi@ti.com>,
*/
-#include <linux/acpi.h>
#include <linux/irq.h>
#include <linux/of.h>
#include <linux/platform_device.h>
@@ -83,7 +82,6 @@ int dwc3_host_init(struct dwc3 *dwc)
}
xhci->dev.parent = dwc->dev;
- ACPI_COMPANION_SET(&xhci->dev, ACPI_COMPANION(dwc->dev));
dwc->xhci = xhci;