diff options
| author |   Gen Zhang <blackgod016574@gmail.com> | 2019-05-31 09:24:18 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-06-02 22:15:35 -0700 |
| commit | 80caf43549e7e41a695c6d1e11066286538b336f (patch) | |
| tree | d023ca98d7b6ba61c8f347a0ac0446638fc89766 | |
| parent | sparc64: Fix regression in non-hypervisor TLB flush xcall (diff) | |
| download | linux-dev-80caf43549e7e41a695c6d1e11066286538b336f.tar.xz linux-dev-80caf43549e7e41a695c6d1e11066286538b336f.zip | |
mdesc: fix a missing-check bug in get_vdev_port_node_info()
In get_vdev_port_node_info(), 'node_info->vdev_port.name' is allcoated
by kstrdup_const(), and it returns NULL when fails. So
'node_info->vdev_port.name' should be checked.
Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | arch/sparc/kernel/mdesc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/sparc/kernel/mdesc.c b/arch/sparc/kernel/mdesc.c index 9a26b442f820..8e645ddac58e 100644 --- a/arch/sparc/kernel/mdesc.c +++ b/arch/sparc/kernel/mdesc.c @@ -356,6 +356,8 @@ static int get_vdev_port_node_info(struct mdesc_handle *md, u64 node, node_info->vdev_port.id = *idp; node_info->vdev_port.name = kstrdup_const(name, GFP_KERNEL); + if (!node_info->vdev_port.name) + return -1; node_info->vdev_port.parent_cfg_hdl = *parent_cfg_hdlp; return 0; |