aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-05-11 14:48:13 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-05-20 07:40:39 +0200
commit80ff4ad4c62f7b7694327712f1aaf5a38eae4a61 (patch)
tree875dd6802287aad5627335f825ee60c528a5ff7f
parentStaging: kpc2000: Cleanup in kpc_dma_transfer() (diff)
downloadlinux-dev-80ff4ad4c62f7b7694327712f1aaf5a38eae4a61.tar.xz
linux-dev-80ff4ad4c62f7b7694327712f1aaf5a38eae4a61.zip
staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret
The variable ret is being initialized however this is never read and later it is being reassigned to a new value. The initialization is redundant and hence can be removed. Addresses-Coverity: ("Unused Value") Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/vc04_services/bcm2835-camera/controls.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index 9841c30450ce..74410fedffad 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -579,7 +579,7 @@ static int ctrl_set_colfx(struct bm2835_mmal_dev *dev,
struct v4l2_ctrl *ctrl,
const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
{
- int ret = -EINVAL;
+ int ret;
struct vchiq_mmal_port *control;
control = &dev->component[MMAL_COMPONENT_CAMERA]->control;