diff options
| author |   Christoph Hellwig <hch@lst.de> | 2022-06-28 19:18:48 +0200 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2022-06-28 11:32:42 -0600 |
| commit | 81f0c2ef41b02185928563899cd4d618ffc7eebf (patch) | |
| tree | 255ec6f3b4c748e5f285a242c9b7038c08ad28ec | |
| parent | block: use default groups to register the queue attributes (diff) | |
| download | linux-dev-81f0c2ef41b02185928563899cd4d618ffc7eebf.tar.xz linux-dev-81f0c2ef41b02185928563899cd4d618ffc7eebf.zip | |
block: remove the extra gendisk reference in __blk_mq_register_dev
kobject_add already grabs a reference to the parent, no need to have
another one.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220628171850.1313069-5-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/blk-mq-sysfs.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/block/blk-mq-sysfs.c b/block/blk-mq-sysfs.c index c08426975856..f4caaa668e3c 100644 --- a/block/blk-mq-sysfs.c +++ b/block/blk-mq-sysfs.c @@ -215,7 +215,6 @@ void blk_mq_unregister_dev(struct device *dev, struct request_queue *q) kobject_uevent(q->mq_kobj, KOBJ_REMOVE); kobject_del(q->mq_kobj); - kobject_put(&dev->kobj); q->mq_sysfs_init_done = false; } @@ -261,7 +260,7 @@ int __blk_mq_register_dev(struct device *dev, struct request_queue *q) WARN_ON_ONCE(!q->kobj.parent); lockdep_assert_held(&q->sysfs_dir_lock); - ret = kobject_add(q->mq_kobj, kobject_get(&dev->kobj), "%s", "mq"); + ret = kobject_add(q->mq_kobj, &dev->kobj, "%s", "mq"); if (ret < 0) goto out; @@ -286,7 +285,6 @@ unreg: kobject_uevent(q->mq_kobj, KOBJ_REMOVE); kobject_del(q->mq_kobj); - kobject_put(&dev->kobj); return ret; } |