diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2021-04-06 17:53:46 +0100 |
|---|---|---|
| committer |   Saeed Mahameed <saeedm@nvidia.com> | 2021-04-14 11:02:58 -0700 |
| commit | 82c3ba31c370b6001cbf90689e98da1fb6f26aef (patch) | |
| tree | fa68ca98b7fbf66d2041d5eccf19457735f4e5cb | |
| parent | net/mlx5: DR, Alloc cmd buffer with kvzalloc() instead of kzalloc() (diff) | |
| download | linux-dev-82c3ba31c370b6001cbf90689e98da1fb6f26aef.tar.xz linux-dev-82c3ba31c370b6001cbf90689e98da1fb6f26aef.zip | |
net/mlx5: Fix bit-wise and with zero
The bit-wise and of the action field with MLX5_ACCEL_ESP_ACTION_DECRYPT
is incorrect as MLX5_ACCEL_ESP_ACTION_DECRYPT is zero and not intended
to be a bit-flag. Fix this by using the == operator as was originally
intended.
Addresses-Coverity: ("Logically dead code")
Fixes: 7dfee4b1d79e ("net/mlx5: IPsec, Refactor SA handle creation and destruction")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c index d43a05e77f67..0b19293cdd74 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c @@ -850,7 +850,7 @@ mlx5_fpga_ipsec_release_sa_ctx(struct mlx5_fpga_ipsec_sa_ctx *sa_ctx) return; } - if (sa_ctx->fpga_xfrm->accel_xfrm.attrs.action & + if (sa_ctx->fpga_xfrm->accel_xfrm.attrs.action == MLX5_ACCEL_ESP_ACTION_DECRYPT) ida_free(&fipsec->halloc, sa_ctx->sa_handle); |