diff options
| author |   Julian Wiedmann <jwi@linux.vnet.ibm.com> | 2017-10-18 17:40:17 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-10-20 13:11:04 +0100 |
| commit | 83cf79a2fec3cf499eb6cb9eb608656fc2a82776 (patch) | |
| tree | 496a9229963dca9f62275675fd722cd9ce89bf4a | |
| parent | s390/qeth: use kstrtobool() in qeth_bridgeport_hostnotification_store() (diff) | |
| download | linux-dev-83cf79a2fec3cf499eb6cb9eb608656fc2a82776.tar.xz linux-dev-83cf79a2fec3cf499eb6cb9eb608656fc2a82776.zip | |
s390/qeth: fix early exit from error path
When the allocation of the addr buffer fails, we need to free
our refcount on the inetdevice before returning.
Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/s390/net/qeth_l3_main.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c index 270ac9515f6b..aadd384316a3 100644 --- a/drivers/s390/net/qeth_l3_main.c +++ b/drivers/s390/net/qeth_l3_main.c @@ -1553,7 +1553,7 @@ static void qeth_l3_free_vlan_addresses4(struct qeth_card *card, addr = qeth_l3_get_addr_buffer(QETH_PROT_IPV4); if (!addr) - return; + goto out; spin_lock_bh(&card->ip_lock); @@ -1567,6 +1567,7 @@ static void qeth_l3_free_vlan_addresses4(struct qeth_card *card, spin_unlock_bh(&card->ip_lock); kfree(addr); +out: in_dev_put(in_dev); } @@ -1591,7 +1592,7 @@ static void qeth_l3_free_vlan_addresses6(struct qeth_card *card, addr = qeth_l3_get_addr_buffer(QETH_PROT_IPV6); if (!addr) - return; + goto out; spin_lock_bh(&card->ip_lock); @@ -1606,6 +1607,7 @@ static void qeth_l3_free_vlan_addresses6(struct qeth_card *card, spin_unlock_bh(&card->ip_lock); kfree(addr); +out: in6_dev_put(in6_dev); #endif /* CONFIG_QETH_IPV6 */ } |