diff options
| author |   Chuck Lever <chuck.lever@oracle.com> | 2006-10-19 23:28:42 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-20 10:26:39 -0700 |
| commit | 85233a7a436a48a0b98e7976a66797e5da79c9d6 (patch) | |
| tree | 3d55b9767194943dd4676e2d84a9e56563f4fed7 | |
| parent | [PATCH] NFS: fix minor bug in new NFS symlink code (diff) | |
| download | linux-dev-85233a7a436a48a0b98e7976a66797e5da79c9d6.tar.xz linux-dev-85233a7a436a48a0b98e7976a66797e5da79c9d6.zip | |
[PATCH] NFS: __nfs_revalidate_inode() can use "inode" before checking it is non-NULL
The "!inode" check in __nfs_revalidate_inode() occurs well after the first
time it is dereferenced, so get rid of it.
Coverity: #cid 1372, 1373
Test plan:
Code review; recheck with Coverity.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | fs/nfs/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 9979ad1cf8eb..08cc4c5919ab 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -583,7 +583,7 @@ __nfs_revalidate_inode(struct nfs_server *server, struct inode *inode) nfs_inc_stats(inode, NFSIOS_INODEREVALIDATE); lock_kernel(); - if (!inode || is_bad_inode(inode)) + if (is_bad_inode(inode)) goto out_nowait; if (NFS_STALE(inode)) goto out_nowait; |