diff options
| author |   Douglas Anderson <dianders@chromium.org> | 2019-07-22 11:24:37 -0700 |
|---|---|---|
| committer |   Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> | 2019-07-26 16:32:26 +0200 |
| commit | 892e8ba38f28d68a17122a9e14cf36ea756aa6b8 (patch) | |
| tree | 017996abc9b1710d7e3ce21b3cc2f03021eba0a5 | |
| parent | video: of: display_timing: Add of_node_put() in of_get_display_timing() (diff) | |
| download | linux-dev-892e8ba38f28d68a17122a9e14cf36ea756aa6b8.tar.xz linux-dev-892e8ba38f28d68a17122a9e14cf36ea756aa6b8.zip | |
video: of: display_timing: Don't yell if no timing node is present
There may be cases (like in panel-simple.c) where we have a sane
fallback if no timings are specified in the device tree. Let's get
rid of the unconditional pr_err(). We can add error messages in
individual drivers if it makes sense.
NOTE: we'll still print errors if the node is present but there are
problems parsing the timings.
Fixes: b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical timing")
Reported-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190722182439.44844-3-dianders@chromium.org
| -rw-r--r-- | drivers/video/of_display_timing.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index 5eedae0799f0..abc9ada798ee 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -125,10 +125,8 @@ int of_get_display_timing(const struct device_node *np, const char *name, return -EINVAL; timing_np = of_get_child_by_name(np, name); - if (!timing_np) { - pr_err("%pOF: could not find node '%s'\n", np, name); + if (!timing_np) return -ENOENT; - } ret = of_parse_display_timing(timing_np, dt); |