diff options
| author |   Stephen Hemminger <shemminger@vyatta.com> | 2009-08-28 12:05:13 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2009-08-28 23:01:15 -0700 |
| commit | 89c76c62f191daa7ede3d1d0c510a5ccfbcae571 (patch) | |
| tree | 2cabba3044f77c344acceae032aeeb6ebe44ab8a | |
| parent | bonding: propogate vlan_features to bonding master (diff) | |
| download | linux-dev-89c76c62f191daa7ede3d1d0c510a5ccfbcae571.tar.xz linux-dev-89c76c62f191daa7ede3d1d0c510a5ccfbcae571.zip | |
bonding: use compare_ether_addr
Bonding can use compare_ether_addr() in bond_release.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/bonding/bond_main.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 1aeb36c51478..ed00ba919d91 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1796,7 +1796,6 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev) struct bonding *bond = netdev_priv(bond_dev); struct slave *slave, *oldcurrent; struct sockaddr addr; - int mac_addr_differ; /* slave is not a slave or master is not master of this slave */ if (!(slave_dev->flags & IFF_SLAVE) || @@ -1820,9 +1819,8 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev) } if (!bond->params.fail_over_mac) { - mac_addr_differ = memcmp(bond_dev->dev_addr, slave->perm_hwaddr, - ETH_ALEN); - if (!mac_addr_differ && (bond->slave_cnt > 1)) + if (!compare_ether_addr(bond_dev->dev_addr, slave->perm_hwaddr) + && bond->slave_cnt > 1) pr_warning(DRV_NAME ": %s: Warning: the permanent HWaddr of %s - " "%pM - is still in use by %s. " |