diff options
| author |   Zach Brown <zach.brown@oracle.com> | 2006-10-03 01:16:15 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-03 08:04:20 -0700 |
| commit | 8b2a1fd1b394c60eaa2587716102dd5e9b4e5990 (patch) | |
| tree | 6317cd01c2a758908f747f2c0b110dd40b9dc6d9 | |
| parent | [PATCH] isdn: more pr_debug() fixes (diff) | |
| download | linux-dev-8b2a1fd1b394c60eaa2587716102dd5e9b4e5990.tar.xz linux-dev-8b2a1fd1b394c60eaa2587716102dd5e9b4e5990.zip | |
[PATCH] pr_debug: check pr_debug() arguments
check pr_debug() arguments
When DEBUG isn't defined pr_debug() is defined away as an empty macro. By
throwing away the arguments we allow completely incorrect code to build.
Instead let's make it an empty inline which checks arguments and mark it so gcc
can check the format specification.
This results in a seemingly insignificant code size increase. A x86-64
allyesconfig:
text data bss dec hex filename
25354768 7191098 4854720 37400586 23ab00a vmlinux.before
25354945 7191138 4854720 37400803 23ab0e3 vmlinux
Signed-off-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | include/linux/kernel.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 4d00988dad03..80f39cab470a 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -216,8 +216,10 @@ extern void dump_stack(void); #define pr_debug(fmt,arg...) \ printk(KERN_DEBUG fmt,##arg) #else -#define pr_debug(fmt,arg...) \ - do { } while (0) +static inline int __attribute__ ((format (printf, 1, 2))) pr_debug(const char * fmt, ...) +{ + return 0; +} #endif #define pr_info(fmt,arg...) \ |