diff options
| author |   Tom Rix <trix@redhat.com> | 2020-07-20 12:18:45 -0700 |
|---|---|---|
| committer |   Sam Ravnborg <sam@ravnborg.org> | 2020-08-05 19:47:22 +0200 |
| commit | 8e1ba47c60bcd325fdd097cd76054639155e5d2e (patch) | |
| tree | cb1cdc9b9312b6037477e462ce1d438889ac0648 | |
| parent | drm/mgag200: Set PCI option register in G200SE models (diff) | |
| download | linux-dev-8e1ba47c60bcd325fdd097cd76054639155e5d2e.tar.xz linux-dev-8e1ba47c60bcd325fdd097cd76054639155e5d2e.zip | |
video: fbdev: pvr2fb: initialize variables
clang static analysis reports this repesentative error
pvr2fb.c:1049:2: warning: 1st function call argument
is an uninitialized value [core.CallAndMessage]
if (*cable_arg)
^~~~~~~~~~~~~~~
Problem is that cable_arg depends on the input loop to
set the cable_arg[0]. If it does not, then some random
value from the stack is used.
A similar problem exists for output_arg.
So initialize cable_arg and output_arg.
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200720191845.20115-1-trix@redhat.com
| -rw-r--r-- | drivers/video/fbdev/pvr2fb.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c index 2d9f69b93392..f4add36cb5f4 100644 --- a/drivers/video/fbdev/pvr2fb.c +++ b/drivers/video/fbdev/pvr2fb.c @@ -1028,6 +1028,8 @@ static int __init pvr2fb_setup(char *options) if (!options || !*options) return 0; + cable_arg[0] = output_arg[0] = 0; + while ((this_opt = strsep(&options, ","))) { if (!*this_opt) continue; |