diff options
| author |   Marek Szyprowski <m.szyprowski@samsung.com> | 2022-01-21 11:00:39 +0100 |
|---|---|---|
| committer |   Inki Dae <inki.dae@samsung.com> | 2022-03-04 17:13:51 +0900 |
| commit | 8e3fa9d841db7517c1dcc365a911eaeacee09f20 (patch) | |
| tree | 41694d064bbe3ce0fb8db9a589e95bf687106d9f | |
| parent | drm/exynos: gsc: Use platform_get_irq() to get the interrupt (diff) | |
| download | linux-dev-8e3fa9d841db7517c1dcc365a911eaeacee09f20.tar.xz linux-dev-8e3fa9d841db7517c1dcc365a911eaeacee09f20.zip | |
drm/exynos: Don't fail if no TE-gpio is defined for DSI driver
TE-gpio is optional and if it is not found then gpiod_get_optional()
returns NULL. In such case the code will continue and try to convert NULL
gpiod to irq what in turn fails. The failure is then propagated and driver
is not registered.
Fix this by returning early from exynos_dsi_register_te_irq() if no
TE-gpio is found.
Fixes: ee6c8b5afa62 ("drm/exynos: Replace legacy gpio interface for gpiod interface")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
| -rw-r--r-- | drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index b7d0a4aead0a..ea42f45b2937 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1336,7 +1336,9 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi, int te_gpio_irq; dsi->te_gpio = devm_gpiod_get_optional(dsi->dev, "te", GPIOD_IN); - if (IS_ERR(dsi->te_gpio)) { + if (!dsi->te_gpio) { + return 0; + } else if (IS_ERR(dsi->te_gpio)) { dev_err(dsi->dev, "gpio request failed with %ld\n", PTR_ERR(dsi->te_gpio)); return PTR_ERR(dsi->te_gpio); |