diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2013-08-09 12:52:31 +0300 |
|---|---|---|
| committer |   John W. Linville <linville@tuxdriver.com> | 2013-08-09 14:01:21 -0400 |
| commit | 909bd5926d474e275599094acad986af79671ac9 (patch) | |
| tree | 0b835315a3adb9468e09d505652a7352bea01fbb | |
| parent | zd1201: do not use stack as URB transfer_buffer (diff) | |
| download | linux-dev-909bd5926d474e275599094acad986af79671ac9.tar.xz linux-dev-909bd5926d474e275599094acad986af79671ac9.zip | |
Hostap: copying wrong data prism2_ioctl_giwaplist()
We want the data stored in "addr" and "qual", but the extra ampersands
mean we are copying stack data instead.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| -rw-r--r-- | drivers/net/wireless/hostap/hostap_ioctl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/hostap/hostap_ioctl.c b/drivers/net/wireless/hostap/hostap_ioctl.c index ac074731335a..e5090309824e 100644 --- a/drivers/net/wireless/hostap/hostap_ioctl.c +++ b/drivers/net/wireless/hostap/hostap_ioctl.c @@ -523,9 +523,9 @@ static int prism2_ioctl_giwaplist(struct net_device *dev, data->length = prism2_ap_get_sta_qual(local, addr, qual, IW_MAX_AP, 1); - memcpy(extra, &addr, sizeof(struct sockaddr) * data->length); + memcpy(extra, addr, sizeof(struct sockaddr) * data->length); data->flags = 1; /* has quality information */ - memcpy(extra + sizeof(struct sockaddr) * data->length, &qual, + memcpy(extra + sizeof(struct sockaddr) * data->length, qual, sizeof(struct iw_quality) * data->length); kfree(addr); |