diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2017-09-18 15:45:48 +0100 |
|---|---|---|
| committer |   Guenter Roeck <linux@roeck-us.net> | 2017-10-29 18:36:03 -0700 |
| commit | 90b863dd63d63f4d97c3f5b6d6ed5bd239500f7b (patch) | |
| tree | f47380a5d82d8d3ead96379b6dfcffed358b64a3 | |
| parent | hwmon: (sht15) Root out platform data (diff) | |
| download | linux-dev-90b863dd63d63f4d97c3f5b6d6ed5bd239500f7b.tar.xz linux-dev-90b863dd63d63f4d97c3f5b6d6ed5bd239500f7b.zip | |
hwmon: (sht15) remove redundant check on status and send of status value
A previous commit removed bit or'ing into to the integer status
so now status is now always zero. This means that the non-zero check on
status and the sht15_send_status call will never occur; it is deadcode.
Clean this up by removing the dead code.
Detected by: CoverityScan CID#1456835 ("Logically dead code")
Fixes: aa7ab80c578c ("hwmon: (sht15) Root out platform data")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/sht15.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c index 0e3e5f83f5cf..25d28343ba93 100644 --- a/drivers/hwmon/sht15.c +++ b/drivers/hwmon/sht15.c @@ -925,7 +925,6 @@ static int sht15_probe(struct platform_device *pdev) { int ret; struct sht15_data *data; - u8 status = 0; data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); if (!data) @@ -1002,13 +1001,6 @@ static int sht15_probe(struct platform_device *pdev) if (ret) goto err_release_reg; - /* write status with platform data options */ - if (status) { - ret = sht15_send_status(data, status); - if (ret) - goto err_release_reg; - } - ret = sysfs_create_group(&pdev->dev.kobj, &sht15_attr_group); if (ret) { dev_err(&pdev->dev, "sysfs create failed\n"); |