aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMicah Morton <mortonm@chromium.org>2022-06-15 21:19:06 +0000
committerMicah Morton <mortonm@chromium.org>2022-07-15 17:35:34 +0000
commit92c005a1176288c98a0dc49f37376da35bbea071 (patch)
treef7592b6de57c011384d1138bc717c04d1ca0fc0c
parentLinux 5.19-rc6 (diff)
downloadlinux-dev-92c005a1176288c98a0dc49f37376da35bbea071.tar.xz
linux-dev-92c005a1176288c98a0dc49f37376da35bbea071.zip
LSM: SafeSetID: fix userns bug in selftest
Not sure how this bug got in here but its been there since the original merge. I think I tested the code on a system that wouldn't let me clone() with CLONE_NEWUSER flag set so had to comment out these test_userns invocations. Trying to map UID 0 inside the userns to UID 0 outside will never work, even with CAP_SETUID. The code is supposed to test whether we can map UID 0 in the userns to the UID of the parent process (the one with CAP_SETUID that is writing the /proc/[pid]/uid_map file). Signed-off-by: Micah Morton <mortonm@chromium.org>
-rw-r--r--tools/testing/selftests/safesetid/safesetid-test.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/safesetid/safesetid-test.c b/tools/testing/selftests/safesetid/safesetid-test.c
index 4b809c93ba36..111dcbcc0491 100644
--- a/tools/testing/selftests/safesetid/safesetid-test.c
+++ b/tools/testing/selftests/safesetid/safesetid-test.c
@@ -194,7 +194,7 @@ static bool test_userns(bool expect_success)
printf("preparing file name string failed");
return false;
}
- success = write_file(map_file_name, "0 0 1", uid);
+ success = write_file(map_file_name, "0 %d 1", uid);
return success == expect_success;
}