diff options
| author |   Álvaro Fernández Rojas <noltari@gmail.com> | 2015-12-15 21:03:48 +0100 |
|---|---|---|
| committer |   Jacek Anaszewski <j.anaszewski@samsung.com> | 2016-01-04 09:57:39 +0100 |
| commit | 93a708dab8175c57977d5eec757dd559128f2353 (patch) | |
| tree | 76c89df0e85a1622e9bc06fa90dcf701ef4ccf8c | |
| parent | leds: bcm6358: Use bcm6358_led_set() in order to get rid of the lock (diff) | |
| download | linux-dev-93a708dab8175c57977d5eec757dd559128f2353.tar.xz linux-dev-93a708dab8175c57977d5eec757dd559128f2353.zip | |
leds: bcm6358: remove unneded lock when checking initial LED status
This lock isn't really needed, since we're only reading the register and
changes made to other LEDs aren't relevant.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
| -rw-r--r-- | drivers/leds/leds-bcm6358.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/leds/leds-bcm6358.c b/drivers/leds/leds-bcm6358.c index a98cc711003d..ab09ea453120 100644 --- a/drivers/leds/leds-bcm6358.c +++ b/drivers/leds/leds-bcm6358.c @@ -99,7 +99,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg, void __iomem *mem, spinlock_t *lock) { struct bcm6358_led *led; - unsigned long flags; const char *state; int rc; @@ -119,7 +118,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg, "linux,default-trigger", NULL); - spin_lock_irqsave(lock, flags); if (!of_property_read_string(nc, "default-state", &state)) { if (!strcmp(state, "on")) { led->cdev.brightness = LED_FULL; @@ -141,7 +139,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg, } else { led->cdev.brightness = LED_OFF; } - spin_unlock_irqrestore(lock, flags); bcm6358_led_set(&led->cdev, led->cdev.brightness); |