diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2019-06-17 17:12:49 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-06-18 21:00:40 -0400 |
| commit | 9476274093a0e79b905f4cd6cf6d149f65e02c17 (patch) | |
| tree | 85219d8c26c8286bf2fcaa0f504b795fb1b82817 | |
| parent | Merge branch 'net-fix-quite-a-few-dst_cache-crashes-reported-by-syzbot' (diff) | |
| download | linux-dev-9476274093a0e79b905f4cd6cf6d149f65e02c17.tar.xz linux-dev-9476274093a0e79b905f4cd6cf6d149f65e02c17.zip | |
net: lio_core: fix potential sign-extension overflow on large shift
Left shifting the signed int value 1 by 31 bits has undefined behaviour
and the shift amount oq_no can be as much as 63. Fix this by using
BIT_ULL(oq_no) instead.
Addresses-Coverity: ("Bad shift operation")
Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/cavium/liquidio/lio_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index 1c50c10b5a16..d7e805749a5b 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -964,7 +964,7 @@ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct) if (droq->ops.poll_mode) { droq->ops.napi_fn(droq); - oct_priv->napi_mask |= (1 << oq_no); + oct_priv->napi_mask |= BIT_ULL(oq_no); } else { tasklet_schedule(&oct_priv->droq_tasklet); } |