diff options
| author |   Michael Walle <michael@walle.cc> | 2022-06-27 19:06:43 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-06-29 14:05:00 +0100 |
| commit | 9577fc5fdc8b07b891709af6453545db405e24ad (patch) | |
| tree | e5a79abd1c7b7281fafa22b5f3561a42f8c7d4a1 | |
| parent | NFC: nxp-nci: Don't issue a zero length i2c_master_read() (diff) | |
| download | linux-dev-9577fc5fdc8b07b891709af6453545db405e24ad.tar.xz linux-dev-9577fc5fdc8b07b891709af6453545db405e24ad.zip | |
NFC: nxp-nci: don't print header length mismatch on i2c error
Don't print a misleading header length mismatch error if the i2c call
returns an error. Instead just return the error code without any error
message.
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/nfc/nxp-nci/i2c.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c index e8f3b35afbee..ae2ba08d8ac3 100644 --- a/drivers/nfc/nxp-nci/i2c.c +++ b/drivers/nfc/nxp-nci/i2c.c @@ -122,7 +122,9 @@ static int nxp_nci_i2c_fw_read(struct nxp_nci_i2c_phy *phy, skb_put_data(*skb, &header, NXP_NCI_FW_HDR_LEN); r = i2c_master_recv(client, skb_put(*skb, frame_len), frame_len); - if (r != frame_len) { + if (r < 0) { + goto fw_read_exit_free_skb; + } else if (r != frame_len) { nfc_err(&client->dev, "Invalid frame length: %u (expected %zu)\n", r, frame_len); @@ -166,7 +168,9 @@ static int nxp_nci_i2c_nci_read(struct nxp_nci_i2c_phy *phy, return 0; r = i2c_master_recv(client, skb_put(*skb, header.plen), header.plen); - if (r != header.plen) { + if (r < 0) { + goto nci_read_exit_free_skb; + } else if (r != header.plen) { nfc_err(&client->dev, "Invalid frame payload length: %u (expected %u)\n", r, header.plen); |