diff options
| author |   Mordechay Goodstein <mordechay.goodstein@intel.com> | 2022-03-04 13:21:27 +0200 |
|---|---|---|
| committer |   Luca Coelho <luciano.coelho@intel.com> | 2022-03-10 09:23:29 +0200 |
| commit | 97374513bbc426cea115882847369efac633ead3 (patch) | |
| tree | cd4727b29f1208458fd3931979efbabcbd2bdf3e | |
| parent | iwlwifi: dbg: in sync mode don't call schedule (diff) | |
| download | linux-dev-97374513bbc426cea115882847369efac633ead3.tar.xz linux-dev-97374513bbc426cea115882847369efac633ead3.zip | |
iwlwifi: dbg: check trigger data before access
Without trigger data set, no point in any collection.
so check that we have the info for collecting the data.
Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220304131517.5fb34fb1f0eb.I4d7f2a4d162e80474540c5caf1194ed7d32977bc@changeid
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
| -rw-r--r-- | drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index d3ac8ea049a4..abf49022edbe 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -2905,6 +2905,11 @@ static void iwl_fw_dbg_collect_sync(struct iwl_fw_runtime *fwrt, u8 wk_idx) if (!test_bit(wk_idx, &fwrt->dump.active_wks)) return; + if (!dump_data->trig) { + IWL_ERR(fwrt, "dump trigger data is not set\n"); + goto out; + } + if (!test_bit(STATUS_DEVICE_ENABLED, &fwrt->trans->status)) { IWL_ERR(fwrt, "Device is not enabled - cannot dump error\n"); goto out; |