diff options
| author |   Matti Linnanvuori <mattilinnanvuori@yahoo.com> | 2007-11-08 08:37:38 -0800 |
|---|---|---|
| committer |   Rusty Russell <rusty@rustcorp.com.au> | 2007-11-19 11:20:43 +1100 |
| commit | 9a4b9708f1f2eaf5edd619df578cf3afec36eb82 (patch) | |
| tree | af45a123f6ac642cc326f16c0c97f2c16a18b662 | |
| parent | virtio: fix module/device unloading (diff) | |
| download | linux-dev-9a4b9708f1f2eaf5edd619df578cf3afec36eb82.tar.xz linux-dev-9a4b9708f1f2eaf5edd619df578cf3afec36eb82.zip | |
module: fix and elaborate comments
Fix and elaborate comments.
Signed-off-by: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
| -rw-r--r-- | kernel/module.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/kernel/module.c b/kernel/module.c index 3202c9950073..91fe6958b6e1 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -81,7 +81,8 @@ int unregister_module_notifier(struct notifier_block * nb) } EXPORT_SYMBOL(unregister_module_notifier); -/* We require a truly strong try_module_get() */ +/* We require a truly strong try_module_get(): 0 means failure due to + ongoing or failed initialization etc. */ static inline int strong_try_module_get(struct module *mod) { if (mod && mod->state == MODULE_STATE_COMING) @@ -952,7 +953,8 @@ static unsigned long resolve_symbol(Elf_Shdr *sechdrs, ret = __find_symbol(name, &owner, &crc, !(mod->taints & TAINT_PROPRIETARY_MODULE)); if (ret) { - /* use_module can fail due to OOM, or module unloading */ + /* use_module can fail due to OOM, + or module initialization or unloading */ if (!check_version(sechdrs, versindex, name, mod, crc) || !use_module(mod, owner)) ret = 0; @@ -1369,7 +1371,7 @@ dup: return ret; } -/* Change all symbols so that sh_value encodes the pointer directly. */ +/* Change all symbols so that st_value encodes the pointer directly. */ static int simplify_symbols(Elf_Shdr *sechdrs, unsigned int symindex, const char *strtab, |