aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorShaohua Li <shli@fb.com>2016-10-27 15:22:13 -0700
committerShaohua Li <shli@fb.com>2016-10-28 22:04:03 -0700
commit9a8b27fac5bbb77337cc2e5d31d37c9936782d87 (patch)
treea10573f48736ba5b5e89fdc6f4f7844fae2ce133
parentmd: report 'write_pending' state when array in sync (diff)
downloadlinux-dev-9a8b27fac5bbb77337cc2e5d31d37c9936782d87.tar.xz
linux-dev-9a8b27fac5bbb77337cc2e5d31d37c9936782d87.zip
raid5-cache: correct condition for empty metadata write
As long as we recover one metadata block, we should write the empty metadata write. The original code could make recovery corrupted if only one meta is valid. Reported-by: Zhengyuan Liu <liuzhengyuan@kylinos.cn> Signed-off-by: Shaohua Li <shli@fb.com>
-rw-r--r--drivers/md/raid5-cache.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index 981f85515191..a227a9f3ee65 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -1087,7 +1087,7 @@ static int r5l_recovery_log(struct r5l_log *log)
* 1's seq + 10 and let superblock points to meta2. The same recovery will
* not think meta 3 is a valid meta, because its seq doesn't match
*/
- if (ctx.seq > log->last_cp_seq + 1) {
+ if (ctx.seq > log->last_cp_seq) {
int ret;
ret = r5l_log_write_empty_meta_block(log, ctx.pos, ctx.seq + 10);