aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDinghao Liu <dinghao.liu@zju.edu.cn>2020-05-27 16:46:08 +0800
committerMark Brown <broonie@kernel.org>2020-05-27 14:48:50 +0100
commit9ad61b5c804090022444719d1f16e1029e002430 (patch)
treeab6020f3e07da5b278ec95d1e18fa4449137af32
parentASoC: tas2552: Fix runtime PM imbalance in tas2552_component_probe (diff)
downloadlinux-dev-9ad61b5c804090022444719d1f16e1029e002430.tar.xz
linux-dev-9ad61b5c804090022444719d1f16e1029e002430.zip
ASoC: img-spdif-out: Fix runtime PM imbalance on error
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Link: https://lore.kernel.org/r/20200527084610.4790-1-dinghao.liu@zju.edu.cn Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/img/img-spdif-out.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/soc/img/img-spdif-out.c b/sound/soc/img/img-spdif-out.c
index 456c462d52fb..b1d8e4535726 100644
--- a/sound/soc/img/img-spdif-out.c
+++ b/sound/soc/img/img-spdif-out.c
@@ -370,8 +370,10 @@ static int img_spdif_out_probe(struct platform_device *pdev)
goto err_pm_disable;
}
ret = pm_runtime_get_sync(&pdev->dev);
- if (ret < 0)
+ if (ret < 0) {
+ pm_runtime_put_noidle(&pdev->dev);
goto err_suspend;
+ }
img_spdif_out_writel(spdif, IMG_SPDIF_OUT_CTL_FS_MASK,
IMG_SPDIF_OUT_CTL);