diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-10-17 11:51:55 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-10-17 09:35:05 +0100 |
| commit | 9d4f20a476ca57e4c9246eb1fa2a61bea2354720 (patch) | |
| tree | 82be205a5c57eee4f4ea279195d2231a9948f158 | |
| parent | net: ethernet: mtk_eth_soc: fix possible memory leak in mtk_probe() (diff) | |
| download | linux-dev-9d4f20a476ca57e4c9246eb1fa2a61bea2354720.tar.xz linux-dev-9d4f20a476ca57e4c9246eb1fa2a61bea2354720.zip | |
net: ethernet: mtk_eth_wed: add missing put_device() in mtk_wed_add_hw()
After calling get_device() in mtk_wed_add_hw(), in error path, put_device()
needs be called.
Fixes: 804775dfc288 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_wed.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c index 099b6e0df619..09bbd05bd83c 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed.c +++ b/drivers/net/ethernet/mediatek/mtk_wed.c @@ -1077,11 +1077,11 @@ void mtk_wed_add_hw(struct device_node *np, struct mtk_eth *eth, get_device(&pdev->dev); irq = platform_get_irq(pdev, 0); if (irq < 0) - return; + goto err_put_device; regs = syscon_regmap_lookup_by_phandle(np, NULL); if (IS_ERR(regs)) - return; + goto err_put_device; rcu_assign_pointer(mtk_soc_wed_ops, &wed_ops); @@ -1124,8 +1124,14 @@ void mtk_wed_add_hw(struct device_node *np, struct mtk_eth *eth, hw_list[index] = hw; + mutex_unlock(&hw_lock); + + return; + unlock: mutex_unlock(&hw_lock); +err_put_device: + put_device(&pdev->dev); } void mtk_wed_exit(void) |