aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWolfram Sang <wsa@kernel.org>2021-06-25 17:17:58 +0200
committerWolfram Sang <wsa@kernel.org>2021-07-02 09:14:46 +0200
commit9d6336831bdc78e5207eaf147cc17228b5e984c3 (patch)
treef613e0b0297d1722373eeb40e6bb60f8984959ca
parenti2c: mpc: Restore reread of I2C status register (diff)
downloadlinux-dev-9d6336831bdc78e5207eaf147cc17228b5e984c3.tar.xz
linux-dev-9d6336831bdc78e5207eaf147cc17228b5e984c3.zip
i2c: ali1535: mention that the device should not be disabled
The comment from the i801 driver is valid here, too, so copy it. Reported-by: Jean Delvare <jdelvare@suse.de> Reviewed-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
-rw-r--r--drivers/i2c/busses/i2c-ali1535.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
index fb93152845f4..ee83c4581bce 100644
--- a/drivers/i2c/busses/i2c-ali1535.c
+++ b/drivers/i2c/busses/i2c-ali1535.c
@@ -508,6 +508,11 @@ static void ali1535_remove(struct pci_dev *dev)
{
i2c_del_adapter(&ali1535_adapter);
release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
+
+ /*
+ * do not call pci_disable_device(dev) since it can cause hard hangs on
+ * some systems during power-off
+ */
}
static struct pci_driver ali1535_driver = {