diff options
| author |   Zhang Qilong <zhangqilong3@huawei.com> | 2020-11-03 22:13:06 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2020-11-09 19:44:29 +0000 |
| commit | a042184c7fb99961ea083d4ec192614bec671969 (patch) | |
| tree | 06b4563faff48e4cda87426dc1d2f7c70a195c9d | |
| parent | spi: tegra20-sflash: fix reference leak in tegra_sflash_resume (diff) | |
| download | linux-dev-a042184c7fb99961ea083d4ec192614bec671969.tar.xz linux-dev-a042184c7fb99961ea083d4ec192614bec671969.zip | |
spi: tegra114: fix reference leak in tegra spi ops
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in two callers(tegra_spi_setup and
tegra_spi_resume), so we should fix it.
Fixes: f333a331adfac ("spi/tegra114: add spi driver")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103141306.5607-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-tegra114.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index ca6886aaa519..a2e5907276e7 100644 --- a/drivers/spi/spi-tegra114.c +++ b/drivers/spi/spi-tegra114.c @@ -966,6 +966,7 @@ static int tegra_spi_setup(struct spi_device *spi) ret = pm_runtime_get_sync(tspi->dev); if (ret < 0) { + pm_runtime_put_noidle(tspi->dev); dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret); if (cdata) tegra_spi_cleanup(spi); @@ -1474,6 +1475,7 @@ static int tegra_spi_resume(struct device *dev) ret = pm_runtime_get_sync(dev); if (ret < 0) { + pm_runtime_put_noidle(dev); dev_err(dev, "pm runtime failed, e = %d\n", ret); return ret; } |