diff options
| author |   WANG Cong <xiyou.wangcong@gmail.com> | 2015-03-04 20:11:43 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-03-05 21:30:44 -0500 |
| commit | a05c2d112c0c4a768bfad47c33f28a15f8cf1193 (patch) | |
| tree | f5272d5f8d03a777ff541b8ff8575d5c085b6c81 | |
| parent | Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next (diff) | |
| download | linux-dev-a05c2d112c0c4a768bfad47c33f28a15f8cf1193.tar.xz linux-dev-a05c2d112c0c4a768bfad47c33f28a15f8cf1193.zip | |
net_sched: move tp->root allocation into route4_init()
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sched/cls_route.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c index 2ecd24688554..bb8a60235d01 100644 --- a/net/sched/cls_route.c +++ b/net/sched/cls_route.c @@ -258,6 +258,13 @@ static unsigned long route4_get(struct tcf_proto *tp, u32 handle) static int route4_init(struct tcf_proto *tp) { + struct route4_head *head; + + head = kzalloc(sizeof(struct route4_head), GFP_KERNEL); + if (head == NULL) + return -ENOBUFS; + + rcu_assign_pointer(tp->root, head); return 0; } @@ -484,13 +491,6 @@ static int route4_change(struct net *net, struct sk_buff *in_skb, return -EINVAL; err = -ENOBUFS; - if (head == NULL) { - head = kzalloc(sizeof(struct route4_head), GFP_KERNEL); - if (head == NULL) - goto errout; - rcu_assign_pointer(tp->root, head); - } - f = kzalloc(sizeof(struct route4_filter), GFP_KERNEL); if (!f) goto errout; |