diff options
| author |   Amitoj Kaur Chawla <amitoj1606@gmail.com> | 2016-02-17 20:33:26 +0530 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-02-18 14:58:47 -0500 |
| commit | a09f4af177d2a5b7dc424aba6ba808f4a674ce81 (patch) | |
| tree | 9233aa47dcf8d8b512eab13565bd0ce711600446 | |
| parent | IFF_NO_QUEUE: Fix for drivers not calling ether_setup() (diff) | |
| download | linux-dev-a09f4af177d2a5b7dc424aba6ba808f4a674ce81.tar.xz linux-dev-a09f4af177d2a5b7dc424aba6ba808f4a674ce81.zip | |
lance: Return correct error code
Failure of kzalloc should cause the enclosing function
to return -ENOMEM, not -ENODEV.
Additionally, removed the following checkpatch warnings:
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: space required before the open parenthesis '('
CHECK: Comparison to NULL could be written "!lp"
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/amd/lance.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c index 256f590f6bb1..3a7ebfdda57d 100644 --- a/drivers/net/ethernet/amd/lance.c +++ b/drivers/net/ethernet/amd/lance.c @@ -547,8 +547,8 @@ static int __init lance_probe1(struct net_device *dev, int ioaddr, int irq, int /* Make certain the data structures used by the LANCE are aligned and DMAble. */ lp = kzalloc(sizeof(*lp), GFP_DMA | GFP_KERNEL); - if(lp==NULL) - return -ENODEV; + if (!lp) + return -ENOMEM; if (lance_debug > 6) printk(" (#0x%05lx)", (unsigned long)lp); dev->ml_priv = lp; lp->name = chipname; |