diff options
| author |   Tomas Bortoli <tomasbortoli@gmail.com> | 2019-07-31 12:19:05 -0300 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2019-08-21 18:39:55 -0300 |
| commit | a10feaf8c464c3f9cfdd3a8a7ce17e1c0d498da1 (patch) | |
| tree | a92b5fb5867a07f0e21477b536be2e0adf442d13 | |
| parent | media: dvb-frontends/cxd2099: Make en_templ constant (diff) | |
| download | linux-dev-a10feaf8c464c3f9cfdd3a8a7ce17e1c0d498da1.tar.xz linux-dev-a10feaf8c464c3f9cfdd3a8a7ce17e1c0d498da1.zip | |
media: ttusb-dec: Fix info-leak in ttusb_dec_send_command()
The function at issue does not always initialize each byte allocated
for 'b' and can therefore leak uninitialized memory to a USB device in
the call to usb_bulk_msg()
Use kzalloc() instead of kmalloc()
Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
Reported-by: syzbot+0522702e9d67142379f1@syzkaller.appspotmail.com
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
| -rw-r--r-- | drivers/media/usb/ttusb-dec/ttusb_dec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/usb/ttusb-dec/ttusb_dec.c b/drivers/media/usb/ttusb-dec/ttusb_dec.c index 1d0afa340f47..3198f9624b7c 100644 --- a/drivers/media/usb/ttusb-dec/ttusb_dec.c +++ b/drivers/media/usb/ttusb-dec/ttusb_dec.c @@ -319,7 +319,7 @@ static int ttusb_dec_send_command(struct ttusb_dec *dec, const u8 command, dprintk("%s\n", __func__); - b = kmalloc(COMMAND_PACKET_SIZE + 4, GFP_KERNEL); + b = kzalloc(COMMAND_PACKET_SIZE + 4, GFP_KERNEL); if (!b) return -ENOMEM; |