aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomas Winkler <tomas.winkler@intel.com>2013-09-16 23:44:45 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-09-26 08:42:44 -0700
commita14c44d82fcff280fd1138574d4480b2bdd40216 (patch)
treecddd0f389008b1a6e5e5ebf8735f52a3fa78ecec
parentmei: push credentials inside the irq write handler (diff)
downloadlinux-dev-a14c44d82fcff280fd1138574d4480b2bdd40216.tar.xz
linux-dev-a14c44d82fcff280fd1138574d4480b2bdd40216.zip
mei: mei_cl_unlink: no need to loop over dev list
we can call list_del_init regardless the client is linked or not it is always properly initialized Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/misc/mei/client.c13
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
index 2ab9d1613ffc..fbd319c506e6 100644
--- a/drivers/misc/mei/client.c
+++ b/drivers/misc/mei/client.c
@@ -318,7 +318,6 @@ int mei_cl_link(struct mei_cl *cl, int id)
int mei_cl_unlink(struct mei_cl *cl)
{
struct mei_device *dev;
- struct mei_cl *pos, *next;
/* don't shout on error exit path */
if (!cl)
@@ -330,14 +329,10 @@ int mei_cl_unlink(struct mei_cl *cl)
dev = cl->dev;
- list_for_each_entry_safe(pos, next, &dev->file_list, link) {
- if (cl->host_client_id == pos->host_client_id) {
- cl_dbg(dev, cl, "remove host client = %d, ME client = %d\n",
- pos->host_client_id, pos->me_client_id);
- list_del_init(&pos->link);
- break;
- }
- }
+ cl_dbg(dev, cl, "unlink client");
+
+ list_del_init(&cl->link);
+
return 0;
}