diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2019-03-07 11:31:55 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-07 09:39:46 -0800 |
| commit | a2ae6da025ed73e4312d983b5e57300bc77090f3 (patch) | |
| tree | f5711a97abb8b6e02f12e1f53aeb022b64c2b395 | |
| parent | ravb: Decrease TxFIFO depth of Q3 and Q2 to one (diff) | |
| download | linux-dev-a2ae6da025ed73e4312d983b5e57300bc77090f3.tar.xz linux-dev-a2ae6da025ed73e4312d983b5e57300bc77090f3.zip | |
peak_usb: fix clang build warning
Clang points out undefined behavior when building the pcan_usb_pro driver:
drivers/net/can/usb/peak_usb/pcan_usb_pro.c:136:15: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]
Changing the function prototype to avoid argument promotion in the
varargs call avoids the warning, and should make this well-defined.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c index d516def846ab..b388406ac0f5 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c @@ -127,7 +127,7 @@ static u8 *pcan_msg_init_empty(struct pcan_usb_pro_msg *pm, /* * add one record to a message being built */ -static int pcan_msg_add_rec(struct pcan_usb_pro_msg *pm, u8 id, ...) +static int pcan_msg_add_rec(struct pcan_usb_pro_msg *pm, int id, ...) { int len, i; u8 *pc; |