diff options
| author |   Rafael Mendonca <rafaelmendsr@gmail.com> | 2022-09-16 17:47:51 -0300 |
|---|---|---|
| committer |   Zack Rusin <zackr@vmware.com> | 2022-09-21 12:15:15 -0400 |
| commit | a40c7f61d12fbd1e785e59140b9efd57127c0c33 (patch) | |
| tree | 569fa09661ff27d0877b20543d7080f62a02b859 | |
| parent | drm: bridge/dw-hdmi-ahb-audio: use strscpy() is more robust and safer (diff) | |
| download | linux-dev-a40c7f61d12fbd1e785e59140b9efd57127c0c33.tar.xz linux-dev-a40c7f61d12fbd1e785e59140b9efd57127c0c33.zip | |
drm/vmwgfx: Fix memory leak in vmw_mksstat_add_ioctl()
If the copy of the description string from userspace fails, then the page
for the instance descriptor doesn't get freed before returning -EFAULT,
which leads to a memleak.
Fixes: 7a7a933edd6c ("drm/vmwgfx: Introduce VMware mks-guest-stats")
Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Reviewed-by: Martin Krastev <krastevm@vmware.com>
Signed-off-by: Zack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220916204751.720716-1-rafaelmendsr@gmail.com
| -rw-r--r-- | drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c index 2aceac7856e2..089046fa21be 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c @@ -1076,6 +1076,7 @@ int vmw_mksstat_add_ioctl(struct drm_device *dev, void *data, if (desc_len < 0) { atomic_set(&dev_priv->mksstat_user_pids[slot], 0); + __free_page(page); return -EFAULT; } |